Skip to content

Fix flaky rewrites tests #18165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix flaky rewrites tests #18165

merged 1 commit into from
Jul 7, 2023

Conversation

rochala
Copy link
Contributor

@rochala rochala commented Jul 7, 2023 •
edited
Loading

Fixes #18164

As Vulpix runs tests in parallel, sometimes cleanup wasn't finished before another compilation started leading to throwing exception https://github.com/lampepfl/dotty/actions/runs/5482337258/jobs/9987578194#step:4:2966

This was probably the cause

ckipp01
ckipp01 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM

@rochala rochala enabled auto-merge (squash) July 7, 2023 09:20
@rochala rochala merged commit 778146a into scala:main Jul 7, 2023
@rochala rochala mentioned this pull request Jul 10, 2023
Closed
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2023-07-07 failed
3 participants
@rochala @ckipp01 @Kordyjan